Use securekey-textarea widget for SA json fields#1408
Open
GnsP wants to merge 1 commit intodata-integrations:developfrom
Open
Use securekey-textarea widget for SA json fields#1408GnsP wants to merge 1 commit intodata-integrations:developfrom
GnsP wants to merge 1 commit intodata-integrations:developfrom
Conversation
GnsP
force-pushed
the
enforce-securekey-for-auth-fields-ui
branch
from
c9f18a3 to
6056874
Compare
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
Can you please add the screenshot in the PR description on how the change was tested?
Contributor
Author
Added a screenshot. |
Contributor
What will be the case for existing pipelines? How will the UI look like? Have we tested it? Also since it has been using |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the widget type for SA json fields from
textboxtosecure-textareaPlease notice the shield icon in the SA json field. Clicking the shield lets the user select one of the secure keys defined in the namespace.
A corresponding PR in cdap-ui adds the securekeys tab in Namespace Admin and also makes the securekey-textarea widget non-editable (so that the user will only be able to add the value as a secure macro).