[PLUGIN-1847] Add SqlServerErrorDetailsProvider#539
Merged
psainics merged 1 commit intodata-integrations:developfrom Jan 29, 2025
Merged
[PLUGIN-1847] Add SqlServerErrorDetailsProvider#539psainics merged 1 commit intodata-integrations:developfrom
psainics merged 1 commit intodata-integrations:developfrom
Conversation
psainics
force-pushed
the
fem/sqlserver
branch
from
77fb559 to
dc844db
Compare
Comment on lines
34
to
42
| protected ErrorType getErrorTypeFromErrorCode(int errorCode, String sqlState) { | ||
| if ((errorCode >= 50000 && errorCode <= 59999) || (errorCode >= 0 && errorCode <= 4999)) { | ||
| // User-defined or low-level errors | ||
| return ErrorType.USER; | ||
| } else if (errorCode >= 60000 && errorCode <= 99999) { | ||
| // System-level errors | ||
| return ErrorType.SYSTEM; | ||
| } else { | ||
| // Errors outside the defined range | ||
| return ErrorType.UNKNOWN; | ||
| } |
Contributor
There was a problem hiding this comment.
how did we came up with this categorization?
Contributor
There was a problem hiding this comment.
Did we verify the categorization?
Contributor
There was a problem hiding this comment.
all 5000-6000 looks to me can also be categorized as USER errors for simplicity: https://learn.microsoft.com/en-us/sql/relational-databases/errors-events/database-engine-events-and-errors-5000-to-5999?view=sql-server-ver16
Contributor
Author
There was a problem hiding this comment.
added the range 5000-6000
psainics
force-pushed
the
fem/sqlserver
branch
from
dc844db to
fff9cbf
Compare
| @Override | ||
| protected ErrorType getErrorTypeFromErrorCode(int errorCode, String sqlState) { | ||
| if ((errorCode >= 50000 && errorCode <= 59999) || (errorCode >= 0 && errorCode <= 4999) | ||
| || (errorCode >= 5000 && errorCode <= 6000)) { |
Contributor
There was a problem hiding this comment.
Why can't we combine it from 0-6000?
psainics
force-pushed
the
fem/sqlserver
branch
from
fff9cbf to
53cfd3a
Compare
itsankit-google
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ErrorDetailsProvider - SqlServer [Source|Sink] plugin
Jira : PLUGIN-1847
Description
Implement Program Failure Exception Handling in SqlServer Source/Sink plugin to catch known errors
Code change
SqlServerErrorDetailsProvider.javaDBUtils.javaSqlServerSink.javaSqlServerSource.javaTests
Raw Logs
POST v3/namespaces/{namespace-id}/apps/{app-id}/workflows/DataPipelineWorkflow/runs/{run-id}/classify
[ { "stageName": "SQL Server4", "errorCategory": "Plugin-'DB Integrity Constraint Violation'-'SQL Server4'", "errorReason": "The INSERT statement conflicted with the CHECK constraint \"CHK_Gender\". The conflict occurred in database \"master\", table \"dbo.users\", column 'gender'. For more details, see https://docs.microsoft.com/en-us/sql/relational-databases/errors-events/database-engine-events-and-errors", "errorMessage": "Error occurred in the phase: 'Writing' with sqlState: '23000', errorCode: '547', errorMessage: The INSERT statement conflicted with the CHECK constraint \"CHK_Gender\". The conflict occurred in database \"master\", table \"dbo.users\", column 'gender'.", "errorType": "USER", "dependency": "true", "errorCodeType": "SQLSTATE", "errorCode": "23000", "supportedDocumentationUrl": "https://docs.microsoft.com/en-us/sql/relational-databases/errors-events/database-engine-events-and-errors" } ]