e2e tests Oracle source#535
Merged
AnkitCLI merged 1 commit intodata-integrations:developfrom Jan 17, 2025
Merged
Conversation
itsmekumari
force-pushed
the
e2e-oraclesource_tests
branch
from
4b3d35e to
705cd0f
Compare
itsmekumari
force-pushed
the
e2e-oraclesource_tests
branch
from
705cd0f to
83d1c42
Compare
oracle-plugin/src/e2e-test/features/source/OracleDesignTimeValidation.feature
Show resolved
Hide resolved
Comment on lines
+424
to
+426
| @Before(order = 1, value = "@CONNECTION") | ||
| public static void setNewConnectionName() { | ||
| String connectionName = "Oracle" + RandomStringUtils.randomAlphanumeric(10); |
Contributor
There was a problem hiding this comment.
This is a common class, we should take connectionPrefix as parameterized, it would not necessary be Oracle for all plugins.
Contributor
Author
There was a problem hiding this comment.
We are having different TestSetupHooks class file for different database plugins. For each database plugin we are using according to the plugin name.
oracle-plugin/src/e2e-test/java/io.cdap.plugin/common.stepsdesign/TestSetupHooks.java
Show resolved
Hide resolved
itsankit-google
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.