Fix the data-ingestion-artifacts references#1
Open
IremErturk wants to merge 1 commit intodata-derp:masterfrom
Open
Fix the data-ingestion-artifacts references#1IremErturk wants to merge 1 commit intodata-derp:masterfrom
IremErturk wants to merge 1 commit intodata-derp:masterfrom
Conversation
I have seen in the readme for fresh start there is `upload-artifacts` function mentioned but I found it confusing to apply additional steps when we are already creating resources through iac terraform code. And also to provide consistency with data-transformation iac code I am suggesting the change. But not sure if seperating artifacts in different bucket has additional advantages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have seen in the readme for fresh start there is
upload-artifactsfunction mentioned but I found it confusing to apply additional steps when we are already creating resources through iac terraform code. And also to provide consistency with data-transformation iac code I am suggesting the change. But not sure if seperating artifacts in different bucket has additional advantages.