Skip to content

Conversation

@sargsyann
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Oct 30, 2025

PR Summary 🚀

  • Upgrade to Chart Version 🆙
    We've upped the chart version to 0.3.15 in charts/base/Chart.yaml. This improvement will ensure our application runs on the latest version and benefits from any new features and optimizations it accommodates! 🎉

  • Upgrade to Application Version 🆙
    In lock-step with the chart version, we've also upgraded our application version to 0.3.15. This means our program will be executing its tasks with the latest capabilities and enhancements. This is great news for us as it ensures we are not left behind and always improving! 🎊

  • KEDA Trigger Section Revamp ⚙️
    We've made some key changes to the KEDA trigger section in charts/base/templates/keda.yaml, which now supports multiple triggers! This is a fantastic move that opens up more possibilities for us in terms of how we handle events. Here's a quick rundown of the advancements we've made:

    • Updated the trigger template to accommodate more than one trigger through iterating over .Values.autoscaling.trigger
    • Improved the authentication reference and metadata extraction using the new range loop 🔄
    • Added conditional checks for authRef and kind hence making our system more robust 🛡️

Keep going, team! This progress is exactly what we need to take our project to the next level! 🌟💪

maxReplicaCount: {{ .Values.autoscaling.maxReplicas }}
triggers:
- type: {{ .Values.autoscaling.trigger.type }}
{{- range .Values.autoscaling.trigger }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets support both trigger and triggers, both with single/list ability, with backward compatibility, check config, ingress, multi-containers options we have with similar ways implemented

- type: memory
metadata:
type: Utilization
value: "75"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • this code chunck seems placed in wrong place and should go into examples/base/with-keda-multiple-triggers.yaml file
  • I see triggers.[].metadata.type has been deprecated in favor to triggers.[].metricType, so lets have helm code/templates and examples be aligned to not use deprecated form: https://keda.sh/docs/2.17/scalers/cpu/#trigger-specification

@@ -1,4 +1,6 @@
{{- if and .Values.autoscaling.enabled .Values.autoscaling.trigger }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this condition seems prevents the case when we pass variable triggers and not trigger

@@ -1,4 +1,6 @@
{{- if and .Values.autoscaling.enabled .Values.autoscaling.trigger }}
{{- $triggersRaw := (coalesce .Values.autoscaling.triggers .Values.autoscaling.trigger) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets name this variable just $triggers

name: {{ include "base.fullname" . }}
minReplicaCount: {{ .Values.autoscaling.minReplicas }}
maxReplicaCount: {{ .Values.autoscaling.maxReplicas }}
triggers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems here we simply can use the following instead of all the range loop block, lets check if this works and have less code form used:

  triggers: {{ toYaml $triggers | nindent 2 }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants