Add service account and role to allow Jupyter pod to manage workers#88
Merged
jacobtomlinson merged 1 commit intodask:masterfrom Aug 7, 2020
Merged
Conversation
gforsyth
approved these changes
Aug 7, 2020
gforsyth
left a comment
gforsyth
left a comment
There was a problem hiding this comment.
Hey @jacobtomlinson -- this looks great!
I tested locally with your changes in dask-kubernetes and I can connect and interact using HelmCluster
Member
Author
|
Awesome thanks for the review @gforsyth |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a service account and role to the Jupyter pod which allows it to manage deployments and view pods and logs.
This is limited to the namespace that the Helm Chart is deployed in but allows users to scale their cluster and access worker logs from within the bundled Jupyter session. It is enabled by default but possible to disable.
This ties in with dask/dask-docker#112 which adds
kubectlto the notebook image and dask/dask-kubernetes#255 which adds theHelmClusterclusater manager.This change should result in both
kubectlandHelmClusterworking without configuration from the Jupyter session provided by this chart.cc @gforsyth