adding volumes and volume mounts to jupyter and worker configs

[lbrindze]

Adds volume and volume mount configs to dask helm template. #76

[darothen]

Hey @TomAugspurger and @jacobtomlinson, we were working on some dask integration details for an internal project and wanted to share the fruits of our labor with the broader community. We didn't see a contributor's guide here, can you guys help us review and (hopefully!) merge this new feature in?

[lbrindze]

Also fwiw we (@jminsk-cc, @darothen and myself, as well as other members of the climacell team), are more than happy to help contribute in other helm related PRs since we are beginning to make this a key part of our data platform moving forward.

[jminsk-cc]

More than happy to work on any other problems. Ran into the issue of not having an easy way to mount volumes onto workers. Accidentally left a review.

[jacobtomlinson]

This looks great. Thanks Climacell team!

You may also want to be aware of #78

Just a couple of comments, could you add descriptions to the new config options and regenerate the README?

[lbrindze]

@jacobtomlinson Sounds good I will update this shortly. I just took a look at #78 and didn't see it before. Do we have a preference here in terms of passing the existing kubernetes yaml api through vs specifically overriding specific variables and passing them one at a time. As this overlaps some with #78 I want to make sure we are only going forward with 1 solution here so any recommendations on how to best proceed here?

[jacobtomlinson]

@lbrindze I see no reason why we couldn't do both.

My general preference is to pass the k8s YAML API through, but having some bespoke options to simplify things for folks new to k8s is also nice to have.

[lbrindze]

@jacobtomlinson updated with the readme comments so if you think both options are good and will be ok to support moving forward I think this is ready to merge (pending any other feedback of course).

[jacobtomlinson]

Very happy to see this thanks @lbrindze