Skip to content

Add donor notification delivery and admin test sends#17

Open
darthnithin wants to merge 6 commits intomainfrom
codex/donor-notifications
Open

Add donor notification delivery and admin test sends#17
darthnithin wants to merge 6 commits intomainfrom
codex/donor-notifications

Conversation

@darthnithin
Copy link
Copy Markdown
Owner

Summary

  • add notification installations for Expo and web push with register/unregister flows
  • deliver donor spend notifications across active installations and add admin-triggered test sends
  • expose notification installation status in the admin user snapshot and add a send-test button in the admin panel
  • add notification pipeline tests and fix the Vercel mobile-web build path for this branch

Verification

  • npm run test:notifications
  • npm run dashboard:typecheck
  • npm run root:typecheck
  • npm run build:mobile-web -w @slugswap/dashboard

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
slugswap Ready Ready Preview, Comment Mar 16, 2026 5:47pm

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f036e540fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

};

const SERVICE_WORKER_PATH = "/notifications-sw.js";
const SERVICE_WORKER_SCOPE = "/app/";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align web push service-worker scope with /app route

The configured scope is "/app/", but the web client is served at /app (see the /app rewrite in apps/dashboard/next.config.mjs), so the registration does not control that page URL. Because ensureWebPushSubscription waits on navigator.serviceWorker.ready, web users opening /app can hang indefinitely when enabling spend alerts and never complete subscription/installation registration.

Useful? React with 👍 / 👎.

@darthnithin
Copy link
Copy Markdown
Owner Author

doesn't work yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant