Add donor notification delivery and admin test sends#17
Add donor notification delivery and admin test sends#17darthnithin wants to merge 6 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f036e540fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
|
|
||
| const SERVICE_WORKER_PATH = "/notifications-sw.js"; | ||
| const SERVICE_WORKER_SCOPE = "/app/"; |
There was a problem hiding this comment.
Align web push service-worker scope with /app route
The configured scope is "/app/", but the web client is served at /app (see the /app rewrite in apps/dashboard/next.config.mjs), so the registration does not control that page URL. Because ensureWebPushSubscription waits on navigator.serviceWorker.ready, web users opening /app can hang indefinitely when enabling spend alerts and never complete subscription/installation registration.
Useful? React with 👍 / 👎.
|
doesn't work yet |
Summary
Verification