Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 074c5e7c67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - `GET /api/get/scan-state` returns scan/status metadata only (`state`, `lastCheckedAt`, `expiresAt`). | ||
| - Barcode payloads are returned by `GET /api/get/barcode`. |
There was a problem hiding this comment.
Remove nonexistent GET endpoint references
These bullets document GET /api/get/scan-state and GET /api/get/barcode, but the dispatcher in apps/dashboard/app/api/get/[action]/route.ts only implements login-url, link-status, accounts, and link; there are no scan-state or barcode actions. Any client built from this README section will receive 404s for the documented paths, so the new guidance is currently misleading and should be corrected to match the implemented API.
Useful? React with 👍 / 👎.
Motivation
scan-statereturns barcode payloads.Description
README.mdto add aGET API integration notessection clarifying that the barcode refresh flow does not use a server-side session cache and thatGET /api/get/scan-statereturns metadata only whileGET /api/get/barcodereturns barcode payloads, and note that clients should keep those endpoints separate.Testing
npm run typecheck, which completed successfully.Codex Task