Skip to content

Clarify GET API integration notes in README#16

Open
darthnithin wants to merge 1 commit intomainfrom
codex/fix-issues-from-commit-comments
Open

Clarify GET API integration notes in README#16
darthnithin wants to merge 1 commit intomainfrom
codex/fix-issues-from-commit-comments

Conversation

@darthnithin
Copy link
Copy Markdown
Owner

Motivation

  • Address documentation inaccuracies in the GET workflow diagrams that implied a server-side session cache and that scan-state returns barcode payloads.

Description

  • Update README.md to add a GET API integration notes section clarifying that the barcode refresh flow does not use a server-side session cache and that GET /api/get/scan-state returns metadata only while GET /api/get/barcode returns barcode payloads, and note that clients should keep those endpoints separate.

Testing

  • Ran workspace type checking with npm run typecheck, which completed successfully.

Codex Task

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
slugswap Ready Ready Preview, Comment Mar 16, 2026 2:45am

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 074c5e7c67

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +109 to +110
- `GET /api/get/scan-state` returns scan/status metadata only (`state`, `lastCheckedAt`, `expiresAt`).
- Barcode payloads are returned by `GET /api/get/barcode`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove nonexistent GET endpoint references

These bullets document GET /api/get/scan-state and GET /api/get/barcode, but the dispatcher in apps/dashboard/app/api/get/[action]/route.ts only implements login-url, link-status, accounts, and link; there are no scan-state or barcode actions. Any client built from this README section will receive 404s for the documented paths, so the new guidance is currently misleading and should be corrected to match the implemented API.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant