Demo: image scaling provides incorrect values#1
Open
paulirish wants to merge 2 commits intodarosh:gh-pagesfrom
Open
Demo: image scaling provides incorrect values#1paulirish wants to merge 2 commits intodarosh:gh-pagesfrom
paulirish wants to merge 2 commits intodarosh:gh-pagesfrom
Conversation
patrickhulce
approved these changes
May 13, 2017
Author
|
@patrickhulce in the meantime https://paulirish.github.io/image-ssim-js/test/browser_test.html has these changes live |
Author
|
ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the demo page forces images into a square, the SSIM values end up being way different than if the images were evaluated on their original aspect ratio and size.
This PR...
cc @patrickhulce
Before and after:
