Conversation
|
Thanks for this PR. It looks like the PR checks didn't run automatically, I'm sorry about that (should be fixed now). The checks would have provided some signal and early feedback on the errors that need to be addressed. As is, this branch fails to even build due to a number of errors. You can run the build locally using |
darlal
left a comment
darlal
left a comment
There was a problem hiding this comment.
It looks like the "Icon Shortcodes" Obsidian plugin still needs to be install separately for this to work. If that's the case it would be preferable to place this feature behind a setting that individual users can enable on their own if they want it, and inform them of this requirement. Updating the Readame with that information would be great as well.
Separately, it would be great to cover these changes with tests.
| rules: { | ||
| '@typescript-eslint/unbound-method': 'error', | ||
| 'no-unused-vars': 'off', | ||
| '@typescript-eslint/no-unsafe-assignment': 'warn', |
There was a problem hiding this comment.
It would be preferable to avoid changing the severity of this rule. Using any disables many type checking rules and changing this severity will lead to a lot of backsliding and build up of these errors/warnings.
| "typescript": "^5.4.5" | ||
| }, | ||
| "dependencies": { | ||
| "@aidenlx/obsidian-icon-shortcodes": "0.9.0", |
There was a problem hiding this comment.
It seems like this project may be inactive/unmaintained, the last commit was from October 2022..?
2 participants
Icon Shortcodes plugin support.