Fix Unicode token boundaries for non-ASCII “Other” scripts#1
Open
Konf wants to merge 2 commits intodarkskygit:masterfrom
Open
Fix Unicode token boundaries for non-ASCII “Other” scripts#1Konf wants to merge 2 commits intodarkskygit:masterfrom
Konf wants to merge 2 commits intodarkskygit:masterfrom
Conversation
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes tokenization for all non-ASCII scripts that go through
SegmentScript::Other, e.g Cyrillic languages, Greek, Armenian, etc.Bug summary
DefaultTextNormalizer::normalizehad explicit split logic for ASCII (normalize_ascii_split), but non-ASCII Other segments were processed as a single token vianormalize_span.Fix
normalize_unicode_splitfunction that acts likenormalize_ascii_split, but for unicode strings and wires that function forSegmentScript::Othertext normalization.