Skip to content

Give option to choose the vertical alignment of covers#19

Open
ferrazpedro wants to merge 2 commits intodarklinkpower:masterfrom
ferrazpedro:feature/cover_vertical_aligment
Open

Give option to choose the vertical alignment of covers#19
ferrazpedro wants to merge 2 commits intodarklinkpower:masterfrom
ferrazpedro:feature/cover_vertical_aligment

Conversation

@ferrazpedro
Copy link

I've used your theme for a long while before all covers were aligned to the top. Since this was my only complaint with it, I'm proposing a option for the user to choose the vertical alignment of the game covers with it defaulting to Top.

@ferrazpedro ferrazpedro changed the title Give option to vertical alignment of covers Give option to choose vertical alignment of covers Nov 22, 2022
@ferrazpedro ferrazpedro changed the title Give option to choose vertical alignment of covers Give option to choose the vertical alignment of covers Nov 22, 2022
@darklinkpower
Copy link
Owner

Have you verified that everything works correctly under all the different settings combinations?

Like enabling and disabling banners, rounded corners, etc.

image

@ferrazpedro
Copy link
Author

ferrazpedro commented Dec 6, 2022

Sorry for the delay in the response, I was traveling. I've tested all of these and it worked fine! When the banner is toggled on and the image don't fill the whole cover art space, it just stays at the top of the layout.

Like this:
image

@darklinkpower
Copy link
Owner

That's not correct, the banners should be on top of the covers

image

@ferrazpedro
Copy link
Author

ferrazpedro commented Dec 8, 2022

I've didn't found any way to bind this element relative to the top of the cover images, to be honest. I'm quite new with WPF, so I'll keep looking for it!

Edit: What I've understood is that the banner element is outside of the box with the cover art. And since these boxes doesn't have their height dynamic, I don't think there will be a good solution to keep these banners relative in these situations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants