Fix unsafe integer conversion in UpdatePortVisibility

[Copilot]

Potential fix for alerts

• Incorrect conversion between integer types

---

Summary

Replaced unsafe uint16() cast with validated convertIntToUint16() in UpdatePortVisibility to prevent integer overflow when port values exceed valid range (0-65535) or are negative.

Changes

• Port conversion validation: Added bounds checking before type conversion from int to uint16
• Error handling: Returns descriptive error if port number is invalid

Before

err = fwd.connection.TunnelManager.DeleteTunnelPort(ctx, fwd.connection.Tunnel, uint16(remotePort), fwd.connection.Options)

After

remotePortUint16, err := convertIntToUint16(remotePort)
if err != nil {
    return fmt.Errorf("error converting remote port: %w", err)
}
err = fwd.connection.TunnelManager.DeleteTunnelPort(ctx, fwd.connection.Tunnel, remotePortUint16, fwd.connection.Options)

This aligns with existing pattern used elsewhere in the file (lines 72, 106, 230).

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

---

Continue Tasks: ❌ 1 failed — View all

[Copilot]

Pull request overview

This PR addresses a code scanning alert about incorrect conversion between integer types in the port forwarding code. The fix replaces an unsafe direct cast from int to uint16 with a call to the existing convertIntToUint16() helper function, which includes proper range validation and error handling.

Changes:

• Added safe integer conversion using convertIntToUint16() before calling DeleteTunnelPort() in the UpdatePortVisibility method

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.