Merged
Conversation
- Replaced Water.css with Classless.css for enhanced styling options. - Updated CSS variables to align with Classless.css standards. - Adjusted various styles for body, blockquote, and components to utilize new variable names. - Improved layout and spacing for better visual consistency. - Ensured color variables are correctly applied for text and backgrounds.
…eator.py - Updated font size in report_creator.py to a fixed value for better consistency. - Refactored CSS styles in default.html to improve readability and maintainability. - Removed redundant CSS rules and organized styles for better structure. - Added dynamic accent color property in JavaScript for improved customization.
Moved BLOCK_STATEMENTS, RESERVED_WORDS, and their associated regex patterns from the format_sql method to class-level attributes in the Sql class. This avoids repeated compilation of regex patterns on every function call. Also extracted the keyword replacement logic into a static method _sql_block_replacer for better performance and readability. Benchmark results (100k iterations): - Original: 4.1982s - Optimized: 3.5011s - Improvement: ~16.6%
- Introduced a new 'footer' parameter in the Markdown class to allow custom footers. - Updated the HTML rendering to include the footer below the main content. - Enhanced CSS styles for footers and adjusted existing styles for better alignment.
…as code), makedown (as code) etc
- Removed "yaml" from the supported languages list in the Language class. - Enhanced the Code class docstring to clarify the usage of language-specific subclasses. - Added explanations for using rc.Code() with strings representing Yaml and Json. - Ensured the language argument is converted to lowercase for consistency.
- Updated the Markdown class to replace the footer parameter with a sublabel parameter. - The sublabel is now rendered below the main content, allowing for additional context. - Adjusted the HTML generation to include the sublabel and removed the footer rendering. - Added CSS styles for the new sublabel to enhance visual separation in the output.
…_mapping Optimized the error keyword matching logic by pre-compiling error keywords into a single regular expression outside the loop. This replaces the repeated iteration over the keyword list for every value with a single `regex.search` call. Benchmark results (5000 items): - 7 keywords: ~36% improvement - 107 keywords: ~55% improvement Also refined the numeric check to explicitly exclude boolean types to avoid potential false positives with negative numbers if booleans were somehow involved in numeric comparisons.
- Added spacing before the hover style for better readability. - Removed bold font-weight from active tab button to improve visual consistency.
- Changed the HTML class for image blocks from "image-block" to "block-image" for consistency. - Updated CSS styles to reflect the new class name and added comprehensive styles for various admonition types (attention, caution, danger, error, hint, important, note, tip, warning). - Integrated new directives (Admonition, TableOfContents, Image, Figure) into the Markdown parser for improved functionality.
- Changed debug log to info level when exiting ReportCreator context to improve log visibility. - Removed unnecessary debug logs related to disabling 'indented_code' rule in Markdown parser. - Updated execution time logging to info level for better performance tracking.
- Downgraded version from 2.0.0 to 1.2.0 in __version__.py. - Added language inference from filename in report_creator.py. - Updated Code class to infer language from label if not provided. - Enhanced utility function _infer_language_from_filename to determine language based on file extension. - Cleaned up default.html by removing unused CSS rules.
… CSS for task list items
- Updated docstring for EventMetric to better describe its purpose. - Changed default color for the EventMetric to use the report's accent color instead of a fixed red. - Added default value for the date parameter in EventMetric. - Enhanced logging to provide more context when evaluating conditions. - Updated trace color settings in EventMetric to only apply if a color is specified. - Changed logging level from debug to info when entering ReportCreator context for better visibility. Added example-public-logs.csv to provide sample data for testing and demonstration purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge feature branch into main