Skip to content

Conversation

@darach
Copy link
Owner

@darach darach commented Jan 26, 2026

Signed-off-by: Darach Ennis darach@gmail.com

Description

Motivation and Context

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement
  • Refactoring (no functional changes)
  • CI/CD changes
  • Dependencies update

Checklist

  • I have read the CONTRIBUTING guide
  • My code follows the project's style guidelines
  • I have run cargo fmt and cargo clippy
  • I have added tests that prove my fix/feature works
  • All new and existing tests pass (cargo test)
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Testing

Performance Impact

Additional Notes

Signed-off-by: Darach Ennis <darach@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21375682654

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 79.778%

Files with Coverage Reduction New Missed Lines %
crates/fionn-core/src/patchable.rs 1 82.26%
crates/fionn-diff/src/diff_tape.rs 3 80.28%
Totals Coverage Status
Change from base Build 21373274077: -0.009%
Covered Lines: 34783
Relevant Lines: 43600

💛 - Coveralls

@github-actions
Copy link

✅ Benchmark Results: No significant regressions

Click to expand benchmark comparison
group                                          main                                    pr
-----                                          ----                                    --
diff_comparison/apply_patch/field_add          1.38    306.1±4.71ns        ? ?/sec     1.00    222.3±3.20ns        ? ?/sec
diff_comparison/apply_patch/field_remove       1.37    318.3±1.04ns        ? ?/sec     1.00    232.7±3.49ns        ? ?/sec
diff_comparison/apply_patch/small_change       1.16    447.3±6.71ns        ? ?/sec     1.00    385.3±5.97ns        ? ?/sec
diff_patch_merge/crdt_lww/single_comparison    2.50      1.6±0.00ns        ? ?/sec     1.00      0.6±0.00ns        ? ?/sec
diffable_ops/deep_clone/nested                 1.90    308.8±6.22ns        ? ?/sec     1.00    162.7±2.11ns        ? ?/sec
diffable_ops/equals_self/array                 1.00     19.7±0.11ns        ? ?/sec     1.17     23.0±0.20ns        ? ?/sec
format/comparison/yaml/simd                    1.21      4.3±0.22µs 227.2 KElem/sec    1.00      3.5±0.03µs 275.4 KElem/sec
format/scaling/json/records/10000              1.16      2.2±0.01ms   195.6 MB/sec     1.00  1863.1±11.34µs   226.6 MB/sec
format/toml/parsing/structural/large           1.43     31.5±2.66µs   451.2 MB/sec     1.00     22.1±0.15µs   643.8 MB/sec
format/yaml/parsing/simd_scan/small            1.20   556.2±26.92ns   409.8 MB/sec     1.00   464.1±70.62ns   491.1 MB/sec
gron_comparison/direct/small                   1.22    562.6±5.30ns    66.1 MB/sec     1.00   463.0±73.55ns    80.3 MB/sec
gron_comparison/tape_based/small               1.18    665.9±5.00ns    55.9 MB/sec     1.00   565.0±29.21ns    65.8 MB/sec
gron_comparison/tape_based_preparsed/small     1.28    363.2±6.45ns   102.4 MB/sec     1.00    283.9±7.59ns   131.0 MB/sec
streaming/chunk_throughput/chunk_size/100      1.00      3.6±0.01ms   333.5 MB/sec     1.20      4.3±0.01ms   277.9 MB/sec
streaming/jsonl_batch_size/optimized/10000     1.00      3.4±0.03ms   351.8 MB/sec     1.27      4.3±0.01ms   277.1 MB/sec
tape_parsing/dson_tape/small                   1.51    380.5±3.50ns    97.7 MB/sec     1.00    252.1±9.78ns   147.6 MB/sec

Threshold: 15% regression triggers warning


Benchmarks compare this PR against main branch

@darach darach merged commit d4df598 into main Jan 26, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants