fix: prevent spurious Lost status during intentional disconnect

[tylerkron]

Summary

• Adds _isDisconnecting flag to DaqifiDevice to distinguish intentional disconnects from unexpected transport drops
• Prevents the spurious Connected → Lost → Disconnected transition when calling Disconnect() — now goes straight to Disconnected
• Unexpected transport losses still correctly report Lost status

Closes #161

Test plan

• New test DaqifiDevice_Disconnect_ShouldNotReportLostStatus verifies no Lost status during intentional disconnect
• Existing test DaqifiDevice_TransportConnectionLost_ShouldUpdateStatus still passes for unexpected drops
• All 9 transport tests pass on both net8.0 and net9.0

🤖 Generated with Claude Code

[qodo-code-review]

Review Summary by Qodo

Prevent spurious Lost status during intentional disconnect

🐞 Bug fix 🧪 Tests

Walkthroughs

Description

• Adds _isDisconnecting flag to distinguish intentional disconnects from unexpected transport
  drops
• Prevents spurious Connected → Lost → Disconnected transition during Disconnect() calls
• New test verifies no Lost status reported during intentional disconnect
• Existing tests for unexpected transport losses remain unaffected

Diagram

flowchart LR
  A["Disconnect called"] --> B["Set _isDisconnecting flag"]
  B --> C["Transport fires StatusChanged"]
  C --> D{"_isDisconnecting?"}
  D -->|Yes| E["Skip Lost state"]
  D -->|No| F["Report Lost status"]
  E --> G["Set Disconnected status"]
  F --> G
  G --> H["Clear _isDisconnecting flag"]

Loading

File Changes

1. src/Daqifi.Core/Device/DaqifiDevice.cs 🐞 Bug fix +6/-2

Add disconnect flag to prevent spurious Lost status

• Added _isDisconnecting private boolean field to track intentional disconnect state
• Set flag to true at start of Disconnect() method
• Reset flag to false in finally block after disconnect completes
• Modified OnTransportStatusChanged() to skip Lost status when _isDisconnecting is true

src/Daqifi.Core/Device/DaqifiDevice.cs

---

2. src/Daqifi.Core.Tests/Device/DaqifiDeviceWithTransportTests.cs 🧪 Tests +23/-1

Add test for intentional disconnect without Lost status

• Added new test DaqifiDevice_Disconnect_ShouldNotReportLostStatus() to verify intentional
 disconnect behavior
• Test connects device, subscribes to status changes, calls disconnect, and asserts Lost status is
 never reported
• Test verifies device transitions directly to Disconnected status
• Existing DaqifiDevice_TransportConnectionLost_ShouldUpdateStatus() test remains unchanged

src/Daqifi.Core.Tests/Device/DaqifiDeviceWithTransportTests.cs

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more