Conversation
--- updated-dependencies: - dependency-name: coverlet.collector dependency-version: 8.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
…let.collector-8.0.1
Progress<T> posts callbacks via the thread pool, causing race conditions where assertions run before callbacks complete. This manifests as flaky failures on .NET 9.0 (e.g. Expected: 250, Actual: 200). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move the assertion from inside the callback (where it incorrectly ran on every intermediate report) to after enumeration completes, validating only the final progress value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Consolidate both coverlet package updates into a single PR. Supersedes #156. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tylerkron
changed the title
tylerkron
deleted the
dependabot/nuget/src/Daqifi.Core.Tests/coverlet.collector-8.0.1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coverlet.collectorfrom 6.0.4 to 8.0.1coverlet.msbuildfrom 6.0.4 to 8.0.1Progress<T>posting callbacks asynchronously to the thread poolSupersedes #156.
Test fix details
Replaced
Progress<T>with a synchronousIProgress<T>implementation in tests so progress callbacks execute inline, eliminating race conditions between callback delivery and assertions. Also fixed a bug in the JSON parser test that assertedMessagesRead == 250inside every callback (including intermediate ones at 100, 200).🤖 Generated with Claude Code