Open
Conversation
joshuahannan
reviewed
Oct 6, 2023
Comment on lines
+441
to
+442
| pub let deserialized: Bool? | ||
| pub let presetSerial: UInt64? |
There was a problem hiding this comment.
How are you planning on getting around the upgrade restrictions that you can't add new fields to existing types?
Contributor
There was a problem hiding this comment.
good point. @sadief i think what we can do is to modify the mint function signature to take in an optional Serial. If an edition is deserialized or not can be part of the edition offchain data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following adjustments to the NFL AllDay smart contract:
Adds a new optional field -
deserializedto an EditionAdds a new optional field -
presetSerialto an EditionValidates that if
deserializedis true,presetSerialmust be setAdds the
deserializedfield to an EditionCreated eventIf the moment is
deserialized, thepresetSerialnumber will be used as the serial for each Moment NFT that is mintedFor @maddenwalker and @Deewai