Skip to content

Convert blocking Task.WaitAll to async/await in concurrency tests #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daohainam merged 2 commits into from
Jan 17, 2026
Merged

Convert blocking Task.WaitAll to async/await in concurrency tests #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9851b4f
Initial plan
Copilot Jan 17, 2026
6097af8
Fix xunit warnings: Convert blocking Task.WaitAll to async/await in c…
Copilot Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions MiniDatabaseEngine.Tests/ConcurrencyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public ConcurrencyTests()
}

[Fact]
public void Concurrent_Inserts_Are_Thread_Safe()
public async Task Concurrent_Inserts_Are_Thread_Safe()
{
var columns = new List<ColumnDefinition>
{
Expand All @@ -37,14 +37,14 @@ public void Concurrent_Inserts_Are_Thread_Safe()
}));
}

Task.WaitAll(tasks.ToArray());
await Task.WhenAll(tasks);

var results = table.SelectAll().ToList();
Assert.Equal(10, results.Count);
}

[Fact]
public void Concurrent_Reads_And_Writes_Are_Thread_Safe()
public async Task Concurrent_Reads_And_Writes_Are_Thread_Safe()
{
var columns = new List<ColumnDefinition>
{
Expand Down Expand Up @@ -95,7 +95,7 @@ public void Concurrent_Reads_And_Writes_Are_Thread_Safe()
}));
}

Task.WaitAll(tasks.ToArray());
await Task.WhenAll(tasks);

var finalRow = table.SelectByKey(1);
Assert.NotNull(finalRow);
Expand Down