Skip to content

Conversation

@carlsmedstad
Copy link
Collaborator

Hey 👋 Arch Linux maintainer here

This ensures the tests pass on Arch Linux, with the following Python and pytest versions:

$ python --version
Python 3.12
$ pytest --version
pytest 8.3.2

See commit messages for details.

Resolves #38

A package in CWD will take precedence over system-installed packages
without sys.path modifications, at least in non-archaic Python versions.
Implement and use the pytest fixture 'http_server'. Also, solve the TODO
of selecting the first available free port instead of a hardcoded one.

Resolves danvk#38
@danvk
Copy link
Owner

danvk commented Aug 27, 2024

The tests pass both before & after this PR for me, so I'll go ahead and merge.

$ python --version
Python 3.11.9
$ pytest --version
pytest 7.2.2

@danvk danvk merged commit 3a6981d into danvk:master Aug 27, 2024
@carlsmedstad
Copy link
Collaborator Author

Much appreciated, thank you! Are you planning to release a new version anytime soon? That would relieve me from having to patch our package.

@danvk
Copy link
Owner

danvk commented Aug 27, 2024

Do you want to become an owner of this package?

@carlsmedstad
Copy link
Collaborator Author

I would not have anything against maintaining it upstream while it is in our repositories, sure. I don't think I would have time or interest to do any major development, however.

@danvk
Copy link
Owner

danvk commented Aug 27, 2024

Great. I've invited you to collaborate on both this repo and the pypi project. If you're interested, I think conversion to Poetry (#36) would be a nice addition to get in.

@carlsmedstad
Copy link
Collaborator Author

Super, good suggestion. I'll start with tagging & publishing 1.3.4 from the current master and go from there, if you don't object :)

@carlsmedstad carlsmedstad deleted the fix-tests branch August 27, 2024 15:27
@danvk
Copy link
Owner

danvk commented Aug 27, 2024

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.3.3; pytest fail in all tests/server_test.py units

2 participants