Lint fixes & improvements #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change package declarations from `hal` to `hal_test` for external API tests - Change package declarations from `store` to `store_test` for store tests - Move tests accessing internal functions/fields to `*_internal_test.go` files: - Move TestNewSunTimes (accesses sunTimes.location) to sun_internal_test.go - Move getShortFunctionName and getStringOrStringSlice tests to util_internal_test.go - Update imports and function calls to use proper package prefixes - Remove util_test.go (tests moved to util_internal_test.go) - Add hal import to test files that now use external package 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Refactors tests to
*_testexternal packages with parallelization and new internal test suites, and colorizesgo testoutput; minor settings updates.package hal_test,package store_test), updating references tohal.*and exported errors (e.g.,hal.ErrEntityNotRegistered).config_internal_test.go,sun_internal_test.go,util_internal_test.goto cover unexported helpers.t.Parallel()across tests/subtests; minor fixes (e.g.,0o644perms).Makefile: pipego test -jsonthroughtestutil/colourise-go-test-output.pyfor colorized test output..claude/settings.local.json: expand allowed commands (rm,git rm,grep).Written by Cursor Bugbot for commit 409680c. This will update automatically on new commits. Configure here.