engine: treat exec.ErrWaitDelay as success in setup commands#42
Open
thewoolleyman wants to merge 1 commit intodanshapiro:mainfrom
Open
engine: treat exec.ErrWaitDelay as success in setup commands#42thewoolleyman wants to merge 1 commit intodanshapiro:mainfrom
thewoolleyman wants to merge 1 commit intodanshapiro:mainfrom
Conversation
Background daemons (e.g. pg_ctl start) can hold stdout/stderr pipes open after the parent exits successfully, causing Go's cmd.Wait() to return ErrWaitDelay. This is not a real failure — the setup command itself completed with exit code 0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thewoolleyman
force-pushed
the
fix-setup-waitdelay
branch
from
e67fd2c to
4432ae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec.ErrWaitDelayas success in setup commands, not failurepg_ctl start) can hold stdout/stderr pipes open after the parent process exits successfully (exit code 0), causing Go'scmd.Wait()to returnErrWaitDelayafter the configuredWaitDelay. This is not a real failure.Dependency
Test plan
TestSetupCommands_*tests passTestSetupCommands_BackgroundDaemonDoesNotFailtest passes🤖 Generated with Claude Code