Skip to content

Added refreshing bar height in onLayout #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcin-adamczewski wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added refreshing bar height in onLayout #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...croller/src/main/java/xyz/danoz/recyclerviewfastscroller/AbsRecyclerViewFastScroller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,7 @@ public void onScrolled(RecyclerView recyclerView, int dx, int dy) {
protected void onLayout(boolean changed, int left, int top, int right, int bottom) {
super.onLayout(changed, left, top, right, bottom);

if (getScrollProgressCalculator() == null) {
onCreateScrollProgressCalculator();
}
onCreateScrollProgressCalculator();

// synchronize the handle position to the RecyclerView
float scrollProgress = getScrollProgressCalculator().calculateScrollProgress(mRecyclerView);
Expand Down
9 changes: 7 additions & 2 deletions ...ain/java/xyz/danoz/recyclerviewfastscroller/calculation/VerticalScrollBoundsProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
*/
public class VerticalScrollBoundsProvider {

private final float mMinimumScrollY;
private final float mMaximumScrollY;
private float mMinimumScrollY;
private float mMaximumScrollY;

public VerticalScrollBoundsProvider(float minimumScrollY, float maximumScrollY) {
mMinimumScrollY = minimumScrollY;
Expand All @@ -20,4 +20,9 @@ public float getMinimumScrollY() {
public float getMaximumScrollY() {
return mMaximumScrollY;
}

public void update(float minimumScrollY, float maximumScrollY) {
mMinimumScrollY = minimumScrollY;
mMaximumScrollY = maximumScrollY;
}
}
19 changes: 13 additions & 6 deletions ...in/java/xyz/danoz/recyclerviewfastscroller/vertical/VerticalRecyclerViewFastScroller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package xyz.danoz.recyclerviewfastscroller.vertical;

import android.content.Context;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.v7.widget.LinearLayoutManager;
import android.support.v7.widget.RecyclerView;
Expand All @@ -21,8 +22,9 @@
*/
public class VerticalRecyclerViewFastScroller extends AbsRecyclerViewFastScroller implements RecyclerViewScroller {

@Nullable private VerticalScrollProgressCalculator mScrollProgressCalculator;
@Nullable private VerticalScreenPositionCalculator mScreenPositionCalculator;
private VerticalScrollProgressCalculator mScrollProgressCalculator;
private VerticalScreenPositionCalculator mScreenPositionCalculator;
private VerticalScrollBoundsProvider boundsProvider;

public VerticalRecyclerViewFastScroller(Context context) {
this(context, null);
Expand All @@ -34,6 +36,13 @@ public VerticalRecyclerViewFastScroller(Context context, AttributeSet attrs) {

public VerticalRecyclerViewFastScroller(Context context, AttributeSet attrs, int defStyleAttr) {
super(context, attrs, defStyleAttr);
init();
}

private void init() {
boundsProvider = new VerticalScrollBoundsProvider(mBar.getY(), mBar.getY() + mBar.getHeight() - mHandle.getHeight());
mScrollProgressCalculator = new VerticalLinearLayoutManagerScrollProgressCalculator(boundsProvider);
mScreenPositionCalculator = new VerticalScreenPositionCalculator(boundsProvider);
}

@Override
Expand All @@ -55,10 +64,8 @@ public void moveHandleToPosition(float scrollProgress) {
mHandle.setY(mScreenPositionCalculator.getYPositionFromScrollProgress(scrollProgress));
}

@Override
protected void onCreateScrollProgressCalculator() {
VerticalScrollBoundsProvider boundsProvider =
new VerticalScrollBoundsProvider(mBar.getY(), mBar.getY() + mBar.getHeight() - mHandle.getHeight());
mScrollProgressCalculator = new VerticalLinearLayoutManagerScrollProgressCalculator(boundsProvider);
mScreenPositionCalculator = new VerticalScreenPositionCalculator(boundsProvider);
boundsProvider.update(mBar.getY(), mBar.getY() + mBar.getHeight() - mHandle.getHeight());
}
}