Skip to content

fix GridLayoutManager and StaggeredGridLayoutManager scroller bar #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xdtianyu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix GridLayoutManager and StaggeredGridLayoutManager scroller bar #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions ...astscroller/calculation/progress/VerticalLinearLayoutManagerScrollProgressCalculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
package xyz.danoz.recyclerviewfastscroller.calculation.progress;

import xyz.danoz.recyclerviewfastscroller.calculation.VerticalScrollBoundsProvider;

import android.support.v7.widget.GridLayoutManager;
import android.support.v7.widget.LinearLayoutManager;
import android.support.v7.widget.RecyclerView;
import android.support.v7.widget.RecyclerView.ViewHolder;
import android.support.v7.widget.StaggeredGridLayoutManager;
import android.view.View;

import java.util.Arrays;

import xyz.danoz.recyclerviewfastscroller.calculation.VerticalScrollBoundsProvider;

/**
* Calculates scroll progress for a {@link RecyclerView} with a {@link LinearLayoutManager}
*/
Expand All @@ -22,8 +26,26 @@ public VerticalLinearLayoutManagerScrollProgressCalculator(VerticalScrollBoundsP
*/
@Override
public float calculateScrollProgress(RecyclerView recyclerView) {
LinearLayoutManager layoutManager = (LinearLayoutManager) recyclerView.getLayoutManager();
int lastFullyVisiblePosition = layoutManager.findLastCompletelyVisibleItemPosition();

RecyclerView.LayoutManager layoutManager = recyclerView.getLayoutManager();

int spanCount = 1;
int lastFullyVisiblePosition = 0;

if (layoutManager instanceof GridLayoutManager) {
spanCount = ((GridLayoutManager) layoutManager).getSpanCount();
}

if (layoutManager instanceof LinearLayoutManager) {
lastFullyVisiblePosition = ((LinearLayoutManager) layoutManager).
findLastCompletelyVisibleItemPosition();
} else if (layoutManager instanceof StaggeredGridLayoutManager) {
int[] into = ((StaggeredGridLayoutManager) layoutManager).
findLastCompletelyVisibleItemPositions(null);
Arrays.sort(into);
lastFullyVisiblePosition = into[into.length - 1];
spanCount = ((StaggeredGridLayoutManager) layoutManager).getSpanCount();
}

View visibleChild = recyclerView.getChildAt(0);
if (visibleChild == null) {
Expand All @@ -32,7 +54,7 @@ public float calculateScrollProgress(RecyclerView recyclerView) {
ViewHolder holder = recyclerView.getChildViewHolder(visibleChild);
int itemHeight = holder.itemView.getHeight();
int recyclerHeight = recyclerView.getHeight();
int itemsInWindow = recyclerHeight / itemHeight;
int itemsInWindow = (recyclerHeight / itemHeight) * spanCount;

int numItemsInList = recyclerView.getAdapter().getItemCount();
int numScrollableSectionsInList = numItemsInList - itemsInWindow;
Expand Down