Team Angie-Shawn-Tanya-Viviane-Vulpes's PR#5
Open
Kitty0123 wants to merge 10 commits intodannyforest:masterfrom
Open
Team Angie-Shawn-Tanya-Viviane-Vulpes's PR#5Kitty0123 wants to merge 10 commits intodannyforest:masterfrom
Kitty0123 wants to merge 10 commits intodannyforest:masterfrom
Conversation
Fixed missing assertions in Vi's e2e test
dannyforest
reviewed
Mar 21, 2024
Owner
dannyforest
left a comment
dannyforest
left a comment
There was a problem hiding this comment.
Analyze: 5/5
Unitaire: 5/5
Intégration: 5/5
E2E: 5/5
| .should('have.value', choice3) | ||
| }) | ||
| }) | ||
| it.only('allows a user to edit a question', () => { |
| it('lets a user delete a question', () => { | ||
| cy.visit('http://localhost:4173/edit') | ||
| cy.get('.delete-button').eq(0).click() | ||
| cy.get('.question-input').eq(1).should('have.value', 'What is 2 + 2?') |
Owner
There was a problem hiding this comment.
Dangereux comme test. Comment on peut garantir ça a chaque fois si un usager peut modifier les questions?
| for (let i = 0; i < +numberOfQuestion; i++) { | ||
| cy.get('.choice-button:eq(0)').should('exist') | ||
| cy.get('button:eq(0)').click() | ||
| cy.wait(300) |
Owner
There was a problem hiding this comment.
En production, on essaierait de trouver un moyen de pas faire attendre autant.
| cy.get('button:eq(0)').click() | ||
| cy.wait(300) | ||
| } | ||
| cy.get('.restart-button').should('exist') |
Owner
There was a problem hiding this comment.
le should ici n'est pas nécessaire
| // Checks if the restart event was emitted | ||
| expect(wrapper.emitted()).toHaveProperty('restart') | ||
| // Checks if the restart event was emitted once | ||
| expect(wrapper.emitted('restart')).toHaveLength(1) |
Owner
There was a problem hiding this comment.
pas vraiment nécessaire ce test. Je vais le compter pareil, mais celui d'en haut était assez
Owner
There was a problem hiding this comment.
cela n'est pas un test d'intégration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.