feat: add clientOptions validation for LLM configurations with tests #22
+137
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces validation logic for clientOptions in LLM configurations to ensure correctness and consistency across the codebase.
Key Changes
src/utils/llm.ts
Added validateClientOptions utility to validate LLM clientOptions against provider-specific rules.
src/run.ts
Integrated validateClientOptions into the Run class, ensuring all graphs are initialized with validated client options.
src/specs/llm.utils.test.ts (new file)
Added comprehensive unit tests for validateClientOptions covering valid and invalid client options.
Why this is needed
Prevents misconfiguration of LLM client options (e.g., unsupported params for a given provider).
Improves stability and developer experience by catching errors early.
Provides test coverage for future maintainability.
Testing
All new tests in src/specs/llm.utils.test.ts pass successfully.
Existing test suite continues to pass without regressions.