feat: add millisecond support to date-time picker#232
Open
WilliamCepeda wants to merge 4 commits intodanielmoncada:masterfrom
Open
feat: add millisecond support to date-time picker#232WilliamCepeda wants to merge 4 commits intodanielmoncada:masterfrom
WilliamCepeda wants to merge 4 commits intodanielmoncada:masterfrom
Conversation
WilliamCepeda
commented
Oct 22, 2025
WilliamCepeda
commented
- extend DateTimeAdapter API with getMilliseconds, setMilliseconds and createDate(milliseconds)
- implement milliseconds in NativeDateTimeAdapter and UnixTimestampDateTimeAdapter
- update createDate and createDateWithOverflow utilities to accept/validate milliseconds
- add showMillisecondsTimer and stepMillisecond inputs; wire millisecond handling in timer and container
- update timer templates/components (timer box maxlength/padding, millisecond controls, enable/disable logic)
- add intl labels for millisecond controls
- adjust native/unix formats to include seconds where needed
- increase timer input width and add milliseconds demo in the app
- extend DateTimeAdapter API with getMilliseconds, setMilliseconds and createDate(milliseconds) - implement milliseconds in NativeDateTimeAdapter and UnixTimestampDateTimeAdapter - update createDate and createDateWithOverflow utilities to accept/validate milliseconds - add showMillisecondsTimer and stepMillisecond inputs; wire millisecond handling in timer and container - update timer templates/components (timer box maxlength/padding, millisecond controls, enable/disable logic) - add intl labels for millisecond controls - adjust native/unix formats to include seconds where needed - increase timer input width and add milliseconds demo in the app
|
@danielmoncada please Accept this Pr is really important to have miliseconds in industry systems |
Owner
|
@WilliamCepeda thanks for the PR. Mind resolving conflicts? |
Author
|
@danielmoncada conflicts resolved |
Owner
|
@WilliamCepeda thanks! let me test locally really quick before a publish |
Owner
|
@WilliamCepeda the addition of ms is causing the unit tests to fail, fyi |
Author
|
@danielmoncada just committed a fix and ran tests locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.