chore: update workflows to use go.mod toolchain#192
Open
academician wants to merge 1 commit intodanielfoehrKn:masterfrom
Open
chore: update workflows to use go.mod toolchain#192academician wants to merge 1 commit intodanielfoehrKn:masterfrom
academician wants to merge 1 commit intodanielfoehrKn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that PR #190 failed to build in CI because of some lints that have been introduced in go. This PR updates the github workflows to use the latest version of actions/setup-go which supports using a
go-version-file(ie, go.mod which has a toolchain line). Running the workflow locally succeeded for me now.Long-term it's probably a good idea to update the go version regularly. But this will unblock other PRs.