fix: Create plugin client with logger set to log level of PluginStore#182
Open
srager13 wants to merge 3 commits intodanielfoehrKn:masterfrom
Open
fix: Create plugin client with logger set to log level of PluginStore#182srager13 wants to merge 3 commits intodanielfoehrKn:masterfrom
srager13 wants to merge 3 commits intodanielfoehrKn:masterfrom
Conversation
Contributor
|
Gentle ping @danielfoehrKn :) |
Author
|
Hi @danielfoehrKn , any chance you could take a look at this PR? It would really help our team's use of kubeswitch (which has been really useful, by the way, so thank you for creating and maintaining it!). |
|
Hate to be a pain, but @danielfoehrKn - I also ran into this problem. The plugin functionality actually works great except for this one issue, which causes logs to interfere with kubeswitch's TUI. This PR fixed the problem for me, but it would be nice not to work off of a fork. If you'd like to test it, you can try the small plugin I just published to add kind entries to kubeswitch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #181
When creating a plugin Client, create a Logger with the log level based on the log level of the PluginStore. Since these two resources use different log modules, add a function to convert the log level as closely as possible.