Normalize quaternion values in parse_mujoco_xml#4
Open
WeihangGuo wants to merge 3 commits intodanieldugas:masterfrom
Open
Normalize quaternion values in parse_mujoco_xml#4WeihangGuo wants to merge 3 commits intodanieldugas:masterfrom
parse_mujoco_xml#4WeihangGuo wants to merge 3 commits intodanieldugas:masterfrom
Conversation
Owner
|
Regarding Issue #5 : It's been a while, but IIRC this has to do with wanting to conform to some blender armature common use cases. I don't remember the exact problem I had without this line, but I would prefer these behavior changes be optional, for example with a flag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I found this repo really helpful for rendering robots. In MuJoCo, quaternions are automatically normalized if they aren’t already, but in Blender, this can cause the object to scale incorrectly.
With this PR, users should now be able to load any XML from the mujoco menagerie
Before:
After:
P.S. I noticed the bone pose still incorrect. It is irrelevant to this PR. I’ll keep investigating that.