Changes from Bioverse HWO project #83
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now uses phase angle and angular separation rather than assuming planets are at quadrature
This reverts commit 0e11d9c.
This reverts commit 40b8104.
This reverts commit ceaf966.
Adding phase info
HPIC integration
updated util.py with functions to calculate exposure time.
working on integrating exposure time calculator into it
small change
Added HWO Survey Object and exposure time calculator
Also added lambertian_phase to utils
Now uses compute_contrast as a separate step from geometric albedo
Added contrast calculation as a separate step in the default case
Default reset imaging generator function wasn't reseting it to be the same as the default pickle file. Default pickle file used SAG13 rather than bergsten occurrence rates.
Adding phase info
Also tested and debugged function in generator
Hpic integration
Default reset imaging generator function wasn't reseting it to be the same as the default pickle file. Default pickle file used SAG13 rather than bergsten occurrence rates.
This reverts commit 0e11d9c.
This reverts commit 40b8104.
This reverts commit ceaf966.
updated util.py with functions to calculate exposure time.
working on integrating exposure time calculator into it
small change
Also tested and debugged function in generator
Now is more consistent with the names of properties in bioverse
now fitting returns best fit for null hypothesis as well
now able to change name of columns used for exposure time calculator
now calculates "accurate" yields, creates survey plan before generating planets
Update master with development branch
nwtuchow
requested review from
chaucer-l,
danielapai,
matiscke and
vivianaugust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are all the changes from our recent HWO-Bioverse project. We might not want to integrate all of these changes. In particular, the hypothesis testing changes might want to be part of another pull request. Also simulating HWO is now done within a separate HWOSurvey instead of the standard direct imaging survey. We may want to merge HWOSurvey and ImagingSurvey.
The HWOSurvey object slightly modifies the standard Bioverse workflow, as the survey object is initialized before the Generator object. This so that we can select targets by running the exposure time calculator, which needs information about the telescope/mission design.
This is just a draft pull request so that we can compare and reconcile the differences. I might make a new branch of the main bioverse branch and copy and paste the changes we'd want to keep as individual commits.
Noah