New Alert Components for the library #116
Open
petercr wants to merge 13 commits intodaniel-norris:masterfrom
Open
New Alert Components for the library #116petercr wants to merge 13 commits intodaniel-norris:masterfrom
petercr wants to merge 13 commits intodaniel-norris:masterfrom
Conversation
Bringing over new changes
Alert takes in 1 prop of color right now
It contains the logic, styling, and prop types
Now all it needs is the doc's to go with it 😂
Also added comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋 not sure if you remember me, but I was working on issue #22 back in Hacktoberfest 🎃
Due to some family reasons... it got pushed back a bit 😄
And then I forgot to finish up what I had done 😅
But here it/they are the
<Alert />components 🎉There are 4 types:
The rest of the details for the components (like props) can be found in
./src/components/alerts/Alert.stories.mdx.I tried looking through the example story MDX code to see how you wanted it done, but I wasn't sure since I haven't used Storybook that much.
I ended up just using they style/syntax that the Storybook docs say to use for MDX.
If it doesn't fit the project's style then you can totally change it 👍
Also, I didn't get to write the tests for the component yet, but I just wanted to push up what I had already done in case I didn't get around to the testing for a while.
Thanks,
Pete