Closed
Conversation
A buffer overflow was reported by CRAN's sanitizers in the `construct` function in `src/blast.c`. The `rep` pointer could read past the end of the buffer, causing a crash. This commit adds a safeguard to the `construct` function to prevent the `symbol` index from exceeding the bounds of the `length` array. This is done by adding a check to the inner `do-while` loop and modifying the outer loop's condition to ensure the index stays within the valid range.
A buffer overflow was reported by CRAN's sanitizers in the `construct` function in `src/blast.c`. The `rep` pointer could read past the end of the buffer, causing a crash. This commit adds a safeguard to the `construct` function to prevent the `symbol` index from exceeding the bounds of the `length` array. This is done by adding a check to the inner `do-while` loop and modifying the outer loop's condition to ensure the index stays within the valid range. A new job has been added to the GitHub Actions workflow to run the R CMD check with the address sanitizer enabled. This will help to catch similar issues in the future.
A buffer overflow was reported by CRAN's sanitizers in the `construct` function in `src/blast.c`. The `rep` pointer could read past the end of the buffer, causing a crash. This commit adds a safeguard to the `construct` function to prevent the `symbol` index from exceeding the bounds of the `length` array. This is done by adding a check to the inner `do-while` loop and modifying the outer loop's condition to ensure the index stays within the valid range. A new job has been added to the GitHub Actions workflow to run the R CMD check with the address sanitizer enabled. This will help to catch similar issues in the future. Leak detection has been enabled by default.
A buffer overflow was reported by CRAN's sanitizers in the `construct` function in `src/blast.c`. The `rep` pointer could read past the end of the buffer, causing a crash. This commit adds a safeguard to the `construct` function to prevent the `symbol` index from exceeding the bounds of the `length` array. This is done by adding a check to the inner `do-while` loop and modifying the outer loop's condition to ensure the index stays within the valid range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15