Binary output and Request filtering #19
Conversation
| DEBUG(r, "%ld bytes read from bucket for request %s", nbytes, r->the_request); | ||
| nbytes = min(nbytes, cfg->max_size - *current_size); | ||
| strncpy(buf, ibuf, nbytes); | ||
| //strncpy(buf, ibuf, nbytes); |
There was a problem hiding this comment.
remove this commented out code, we know from the history.
|
|
||
| // condition taken from mod_security | ||
| #if AP_SERVER_MAJORVERSION_NUMBER > 1 && AP_SERVER_MINORVERSION_NUMBER > 2 | ||
| #if AP_SERVER_MAJORVERSION_NUMBER > 1 && AP_SERVER_MINORVERSION_NUMBER > 2 |
There was a problem hiding this comment.
Why changing the alignment here ? and below..
|
|
||
| //Test buffer to search non ASCII characters | ||
| int not_bin=1; | ||
| for (int i = 0; i < state->log_size; i++) |
There was a problem hiding this comment.
can you align similar to other code ? 2 spaces, and {
} style ?
| if (state->buffer[i]<0x20 || state->buffer[i]>0x7E) { | ||
| if (state->buffer[i]=='\n') continue; | ||
| if (state->buffer[i]=='\r') continue; | ||
| not_bin=0; |
There was a problem hiding this comment.
So "not_bin" == 0 mean it is binary ? this is a weird name, how about initialize it at 0 and not_bin = 1 here then ?
But honestly, I think you should drop this check -- if the user specify "I want to get hex" then we should just hex it, the data doesn't matter..
| apr_bucket *b; | ||
| apr_status_t ret; | ||
| /* restoring state */ | ||
| apr_status_t ret; |
| cfg->pool = mp; | ||
| cfg->file = 0; | ||
| cfg->log_bin = 0; | ||
| cfg->filters = apr_array_make(mp, 0, sizeof(char *)); |
|
Sorry about alignment stuff maybe i have some misconfiguration because alignment is good on my editor (sublime text) About the binary dumping, in my case i prefer to display ascii ones plain and the binary ones in hex string, because in my workflow i have some plain data requests before getting a binary blob with data, for me is easier to identify this data quickly instead having all the log in hex and having to decode all of them... Dont get it wrong As you can see im doing development around very specific tasks, and adapting the module to what i need, so fell free to close this PR and use the chunks of my commit if you want on future updates. Note that i didn't properly tested this yet. |
2 participants
Here you go, #18
Cleaned a bit and added settings for binary dumping and filtering urls.