Add per-asset dataStandard, HED standard, and extensions to StandardsType#371
Open
yarikoptic wants to merge 2 commits intomasterfrom
Open
Add per-asset dataStandard, HED standard, and extensions to StandardsType#371yarikoptic wants to merge 2 commits intomasterfrom
yarikoptic wants to merge 2 commits intomasterfrom
Conversation
…s on StandardsType - Bump DANDI_SCHEMA_VERSION to 0.8.0, add 0.7.0 to ALLOWED_INPUT_SCHEMAS - Add `dataStandard: Optional[List[StandardsType]]` to BareAsset for per-asset standard declarations (NWB, BIDS, HED, OME/NGFF) - Add `version: Optional[str]` to StandardsType - Add `extensions: Optional[List["StandardsType"]]` (self-referencing) to StandardsType for NWB ndx-* extensions, HED library schemas, etc. - Add `hed_standard` constant (RRID:SCR_014074) - Collect per-asset dataStandard in aggregate_assets_summary(), with deprecated path/encoding heuristic fallbacks (remove after 2026-12-01) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…cklist Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 97.91% 97.82% -0.10%
==========================================
Files 18 18
Lines 2401 2432 +31
==========================================
+ Hits 2351 2379 +28
- Misses 50 53 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataStandard: Optional[List[StandardsType]]field toBareAssetso dandi-cli can declare per-asset data standards (NWB, BIDS, HED, OME/NGFF) that flow through toAssetsSummaryduring aggregationversion: Optional[str]field toStandardsTypeto track standard versions (e.g. NWB 2.7.0, BIDS 1.9.0, HED 8.2.0)extensions: Optional[List[StandardsType]]self-referencing field toStandardsTypefor standard extensions (NWB ndx-* extensions, HED library schemas)hed_standardconstant alongside existingnwb_standard,bids_standard,ome_ngff_standarddataStandardentries inaggregate_assets_summary(), with deprecated heuristic fallbacks for older clients (remove after 2026-12-01)dataStandardinmigrate()_FIELDS_INTRODUCEDfor downgrade pruningCLAUDE.mdwith architecture docs and schema change checklistCompanion dandi-cli PR: dandi/dandi-cli#XXXX
Test plan
test_hed_standard_structure— verifies hed_standard has correct name, identifier, schemaKeytest_aggregate_per_asset_datastandard— HED declared per-asset flows to summarytest_aggregate_per_asset_datastandard_no_duplication— BIDS not duplicated when declared both per-asset and via heuristicPR in dandi-cli:
🤖 Generated with Claude Code