Skip to content

Remove lodash runtime requirement #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glitchassassin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove lodash runtime requirement #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a003ef3
Removing lodash runtime dependency
glitchassassin Jan 22, 2023
9db5c7d
Updated chapterAndVerse.js
glitchassassin Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions chapterAndVerse.js
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions js/getBook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
const _ = require('lodash')
const books = require('./books.json')
const osis = require('./osis.json')
const errors = require('./errors')
Expand All @@ -7,7 +6,7 @@ const getVerses = require('./getVerses')

function CV(book, reason) {
this.book = book
const vpcBook = _.find(books, {id: book.id})
const vpcBook = books.find(b => b.id === book.id)
this.book.versesPerChapter = vpcBook.chapters

this.success = true
Expand Down Expand Up @@ -73,7 +72,7 @@ CV.prototype.next = function() {
}

let cv
const nextBook = _.find(osis, {order: this.book.order + 1})
const nextBook = osis.find(o => o.order === this.book.order + 1)

if (this.getType() === 'book') {
return (nextBook) ? new CV(nextBook, NEXT.BOOK) : errors.nextBook
Expand Down Expand Up @@ -123,7 +122,7 @@ CV.prototype.prev = function() {
}

let cv
const prevBook = _.find(osis, {order: this.book.order - 1})
const prevBook = osis.find(o => o.order === this.book.order - 1)

if (this.getType() === 'book') {
return (prevBook) ? new CV(prevBook, PREV.BOOK) : errors.prevBook
Expand Down
Loading