Skip to content

Add the ability to use bash variables when setting keys #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fattredd wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add the ability to use bash variables when setting keys #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd80341
Now able to use bash variable substitution when setting keys
Apr 22, 2022
33f32c7
Merge branch 'master' into feature/multiWord
fattredd Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,6 @@ RUN ALL TEST CASES:
11 kvclear; kvlist => line count = 0 [ OK ]
12 kvget return empty value => error code != 0 [ OK ]
13 spaces in value [ OK ]
14 spaces in value with substitution [ OK ]
15 spaces in value without quotes [ OK ]
```
4 changes: 2 additions & 2 deletions kv-bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,14 @@ kvget() {
# Usage: kvset <key> [value]
kvset() {
key="$1"
value="$2"
value="${@:2}"
kv_validate_key "$key" || {
kv_echo_err_box 'invalid param "key"' 'kvset()'
return 1
}
kv_user_dir=${KV_USER_DIR:-$default_kv_user_dir}
test -d "$kv_user_dir" || mkdir "$kv_user_dir"
echo "$value" > "$kv_user_dir/$key"
echo "${value[@]}" > "$kv_user_dir/$key"
}

# Usage: kvdel <key>
Expand Down
16 changes: 15 additions & 1 deletion kv-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,20 @@ TESTCASE 'spaces in value'
RESULT
kvdel name

TESTCASE 'spaces in value with substitution'
test="fizz buzz"
kvset name "foo bar $test"
[ "$(kvget name)" == "foo bar fizz buzz" ]
RESULT
kvdel name

TESTCASE 'spaces in value without quotes'
test="fizz buzz"
kvset name foo bar $test
[ "$(kvget name)" == "foo bar fizz buzz" ]
RESULT
kvdel name

TESTCASE 'can change user dir'
kvclear
kvset Foo Bar
Expand All @@ -112,7 +126,7 @@ TESTCASE 'can return to old user dir'
[ $(kvlist | wc -l) == 1 ]
RESULT
kvclear

#more testcase here

echo