Skip to content

Support varchar/char in postgres-engine, update webview not available msg #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keemsisi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support varchar/char in postgres-engine, update webview not available msg #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa806c1
Added support for varchar for postgres engine, and unified webview me…
keemsisi Aug 30, 2025
a1926aa
Merge branch 'main' into keemsisi/devdb/additional-postgresql-type-su…
keemsisi Aug 30, 2025
a01d164
Merge branch 'main' into keemsisi/devdb/additional-postgresql-type-su…
damms005 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/database-engines/postgres-engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export class PostgresEngine implements DatabaseEngine {
}

getPlainStringTypes(): string[] {
return ['character', 'character varying', 'text', 'json', 'jsonb'];
return ['character', 'character varying', 'varchar', 'char', 'text', 'json', 'jsonb'];
}

async getTotalRows(table: string, columns: Column[], whereClause?: Record<string, any>): Promise<number> {
Expand Down
7 changes: 4 additions & 3 deletions src/devdb-view-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { logToOutput } from './services/output-service';

export class DevDbViewProvider implements vscode.WebviewViewProvider {
public static readonly viewType = 'devdb';
private static readonly webViewNotAvailableMsg = `Message received but the webview not available`;

private _view?: vscode.WebviewView;
private _extensionUri: vscode.Uri;
Expand Down Expand Up @@ -42,7 +43,7 @@ export class DevDbViewProvider implements vscode.WebviewViewProvider {
webviewView.webview.html = getWebviewHtml(webviewView.webview, this.jsFile, this.cssFile, this._extensionUri);

webviewView.webview.onDidReceiveMessage(async (data) => {
if (!this._view) return logToOutput(`Message received but the webview not available`)
if (!this._view) return logToOutput(DevDbViewProvider.webViewNotAvailableMsg)

await handleIncomingMessage(data, this._view)
});
Expand All @@ -54,7 +55,7 @@ export class DevDbViewProvider implements vscode.WebviewViewProvider {
}

public setActiveTable(table: string) {
if (!this._view) return logToOutput(`Message received but the webview not available`)
if (!this._view) return logToOutput(DevDbViewProvider.webViewNotAvailableMsg)

if (!isTablesLoaded()) {
return showEmptyTablesNotification()
Expand All @@ -67,7 +68,7 @@ export class DevDbViewProvider implements vscode.WebviewViewProvider {
}

public async sendUnsolicitedResponse(command: string, response: unknown) {
if (!this._view) return logToOutput(`Message received but the webview not available`)
if (!this._view) return logToOutput(DevDbViewProvider.webViewNotAvailableMsg)

await reply(this._view.webview, command, response)
}
Expand Down