Merged
Conversation
- Removed old Xcode project files and workspace configurations. - Deleted obsolete Info.plist files for both the main plugin and tests. - Cleaned up NavigationBar and NavigationBarPlugin implementation files. - Introduced new Swift Package Manager structure with Package.swift. - Added new source files for NavigationBar and NavigationBarPlugin. - Implemented unit tests for NavigationBar functionality. - Updated package.json to reflect new structure and dependencies. - Added .gitignore for Swift package management artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the project’s build tooling, platform support, and documentation. The most important changes are the addition of Swift Package Manager (SPM) support for iOS, major upgrades to CI/CD workflows and dependencies, and enhancements to code quality tooling. These updates modernize the project, improve maintainability, and align with community best practices.
Platform Support and Packaging:
Package.swiftto provide Swift Package Manager (SPM) support for iOS, enabling easier integration and dependency management for iOS projects.WebnativellcCapacitorNavigationBar.podspec, changed deployment target to iOS 14, and restructured source files for better organization.CI/CD and Build Tooling:
.github/workflows/main.ymlto use Node.js 20, Java 21 (Zulu), macOS 15 runner, latest GitHub Actions versions (v4), and added a dedicated lint job for improved code quality checks. [1] [2]gradlew,gradlew.bat) for better error handling and compliance, including SPDX license headers. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Documentation and Code Quality:
README.mdto use explicit event names, added a changelog for version 7.1.0, and described new features and internal improvements. [1] [2] [3] [4] [5].gitignorefor iOS and removed obsolete Xcode workspace files to clean up the repository. [1] [2] [3]These changes collectively modernize the project, streamline development workflows, and improve integration with iOS and Android platforms.