Skip to content

Comments

add quotes for output#57

Open
vonweb wants to merge 2 commits intodamianociarla:masterfrom
vonweb:master
Open

add quotes for output#57
vonweb wants to merge 2 commits intodamianociarla:masterfrom
vonweb:master

Conversation

@vonweb
Copy link

@vonweb vonweb commented Aug 15, 2019

when there is space in output, program will fail

the version published to npm is behind master, inputs is not quoted either

@tettusud
Copy link

How can I download this fixed version?

@vonweb
Copy link
Author

vonweb commented Aug 23, 2019

How can I download this fixed version?

@tettusud Since the author hasn't merge this PR, You can fork your own or install my fork

yarn add https://github.com/vonweb/node-ffmpeg
npm install https://github.com/vonweb/node-ffmpeg

@ultimate-tester
Copy link

First thing I ran into when trying this module. @damianociarla could you please merge this? It's a blocking defect. Manually putting quotes around it won't fix it, because then the mkdir command fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants