Remove the dependency on the ruby racer.#31
Open
gnedster wants to merge 1 commit intodamian:masterfrom
Open
Conversation
Owner
|
This looks good - thanks for your PR. I'll probably not merge this till #28 is resolved, as they both seem like issues that ought to go in to v2. Hope that's cool with you 😄 |
Author
|
No worries, looking forward to the next version of this gem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love the gem, but instead of having a dependency on therubyracer, we can leave the selection of the JS runtimes up to the user (node, therubyrhino, JavaScriptCore). This convention follows the jshintrb gem and gives more flexibility with no functional loss.
Updated the minor version since some users may depend on this gem to include therubyracer.