Returning keyword names #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plication/xml MIME type, variable name changes
Non-argument calls return value, argument calls doesn't Dynamic importing of library Example for dynamic import created Replacing gorilla-xmlrpc with forked version to get arguments in Runner for start
Hi-Fi
force-pushed
the
basic_functionalities
branch
from
9c24dfe to
d544de6
Compare
golangcibot
reviewed
Jan 12, 2020
runner/runner.go
Outdated
| RPC.RegisterCodec(xmlrpcCodec, "text/xml") | ||
| protocolType := new(protocol.RobotRemoteService) | ||
| protocolType.InitilizeRemoteLibrary(library) | ||
| RPC.RegisterService(protocolType, "") |
There was a problem hiding this comment.
Error return value of RPC.RegisterService is not checked (from errcheck)
Hi-Fi
force-pushed
the
basic_functionalities
branch
from
4ac21a8 to
59dbf38
Compare
Owner
|
Thanks for the PR! I'll take a look when I get some time. |
Author
No hurry, there's still some things to do before it can be said to be "done", but at least the version here is able to utilize go-based libraries, and be used (I think) simple way. I'm showing this server as part of demos at https://robocon.io/#robot-framework-remote-library-in-practice-(with-demos), so there might be some interest towards repo coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-argument calls return value, argument calls doesn't
Dynamic importing of library
Example for dynamic import created
Replacing gorilla-xmlrpc with forked version to get arguments in
Tested also with RF running