-
Notifications
You must be signed in to change notification settings - Fork 23
Plans password #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans password #49
Conversation
|
Hi there, to improve the security and confidentiality of plans, I think it might be worth considering client-side encryption. Encryption at client level could reduce the risk of a malicious user retrieving the data being transferred (for example, between a reverse proxy and explain.dalibo.com). There are a few project using that kind of encryption (e.g. LUFI, I can try tod find and share more examples if you want. Best regards, |
Thanks. I'll have a look. |
|
#51 shows a different implementation (with client-side encryption). This works well. The only possible drawback I see is that it will not be possible (or at least not easy) to post password encrypted plans without the user interface (via cURL for example). |
|
As discussed offline, we decided not to encrypt the plans. In the new implementation (8e2e0d9), the password is stored hashed however. It's rather simple but possibly sufficient for now. End-to-end encryption will possibly be implemented later but would require more important changes. |
migrations/versions/a9ed4fe59f75_add_support_for_plans_password_.py
Outdated
Show resolved
Hide resolved
The password is stored hashed.
Fixes #15