Skip to content

Conversation

@pgiraud
Copy link
Member

@pgiraud pgiraud commented Jun 3, 2025

Fixes #15

@pgiraud pgiraud requested a review from MarionGiusti June 3, 2025 14:15
@l00ptr
Copy link

l00ptr commented Jun 5, 2025

Hi there,

to improve the security and confidentiality of plans, I think it might be worth considering client-side encryption. Encryption at client level could reduce the risk of a malicious user retrieving the data being transferred (for example, between a reverse proxy and explain.dalibo.com).

There are a few project using that kind of encryption (e.g. LUFI, I can try tod find and share more examples if you want.

Best regards,

@pgiraud
Copy link
Member Author

pgiraud commented Jun 5, 2025

Hi there,

to improve the security and confidentiality of plans, I think it might be worth considering client-side encryption. Encryption at client level could reduce the risk of a malicious user retrieving the data being transferred (for example, between a reverse proxy and explain.dalibo.com).

There are a few project using that kind of encryption (e.g. LUFI, I can try tod find and share more examples if you want.

Thanks. I'll have a look.
Apparently, LUFI relies on Stanford Javascript Crypto Library. But it may be possible to use the Crypto Web API.

@pgiraud
Copy link
Member Author

pgiraud commented Jun 6, 2025

#51 shows a different implementation (with client-side encryption). This works well. The only possible drawback I see is that it will not be possible (or at least not easy) to post password encrypted plans without the user interface (via cURL for example).

@pgiraud
Copy link
Member Author

pgiraud commented Jun 16, 2025

As discussed offline, we decided not to encrypt the plans. In the new implementation (8e2e0d9), the password is stored hashed however. It's rather simple but possibly sufficient for now.

End-to-end encryption will possibly be implemented later but would require more important changes.

The password is stored hashed.
@pgiraud pgiraud merged commit 6a8fb6f into main Jun 19, 2025
1 check passed
@pgiraud pgiraud deleted the plans_password branch June 19, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a password when creating a plan

3 participants