fix: prevent top frame navigation when loading homepage#7
Open
sissbruecker wants to merge 1 commit intodaisylb:masterfrom
Open
fix: prevent top frame navigation when loading homepage#7sissbruecker wants to merge 1 commit intodaisylb:masterfrom
sissbruecker wants to merge 1 commit intodaisylb:masterfrom
Conversation
|
Hey, @sissbruecker I've made a fork of New Tab Extension It includes your fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently just opening a new tab can result in the home page being loaded into the top frame, which has the negative side effect that the address bar is now filled with the home page's URL. The issue is that the
onBeforeNavigatelistener can already be triggered by setting the initial home page URL on the new tab iframe here:newtab/newtab.js
Line 8 in 5529c79
This change fixes the issue by preventing the listener from changing the top frame location if the URL being navigated to is the home page.
Fixes #4