basic testing of shim_filesystem.rs using tempfile dev-dep#491
Open
moritz-gross wants to merge 1 commit intodaisy:mainfrom
Open
basic testing of shim_filesystem.rs using tempfile dev-dep#491moritz-gross wants to merge 1 commit intodaisy:mainfrom
shim_filesystem.rs using tempfile dev-dep#491moritz-gross wants to merge 1 commit intodaisy:mainfrom
Conversation
moritz-gross
changed the title
shim_filesystem.rs using tempfile dev-dep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo test --lib shim_filesystem::tests:passesI've only heard the word "shim" once in a video game, so I thought it was made up 😬
test coverage showed 0% for this file (can that really be correct?), so I figured it makes sense to start.
adding
tempfileas dev dependency looks like the easiest way to me.not sure about the
cfgpart that I added. but it follows the earlier parts of the file.wasmis WebAssembly I assume? haven't worked with that yet, so I have only very surface level knowledge.It looks like a hard requirement to use zip for wasm, but how/why are zip files used for other platforms?