Skip to content

Clarify usage instructions in PythonScripts/README.md#487

Closed
moritz-gross wants to merge 2 commits intodaisy:mainfrom
moritz-gross:small-test
Closed

Clarify usage instructions in PythonScripts/README.md#487
moritz-gross wants to merge 2 commits intodaisy:mainfrom
moritz-gross:small-test

Conversation

@moritz-gross
Copy link
Contributor

No description provided.

@moritz-gross
Copy link
Contributor Author

  • pre release is skipped, so that part worked
  • failing checks are unrelated to my changes I think:

error[E0599]: no method named join found for enum std::result::Result<T, E> in the current scope
--> src/bin/mathml2text.rs:89:84

  • let's see if I can merge this once the checks pass.

@NSoiffer
Copy link
Collaborator

Someone else added a CLI interface and that was failing. I've fixed it up.

@moritz-gross
Copy link
Contributor Author

ok, CI passes now.

I still can't approve the PR though. looks like CODEOWNERS (at least how I configured it here) is about who must review, not who can approve in the end. makes sense that those are two different things.

maybe still not bad to have, idk, but I think this is something you'd have to configure in the repo settings I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments