Open
Conversation
houserjohn
commented
Apr 24, 2022
houserjohn
commented
- Removed redundant input for the google drive id (now there is only a spot for google drive URL). Also confirmed that the google drive id is still properly updated whenever the URL is updated as well.
- Changed the icons for opening the google drive folder
- A warning that Google Drive is not configured will be displayed only before save is clicked and the URL has not previously been entered
* Removed redundant input for the google drive id (now there is only a spot for google drive URL). Also confirmed that the google drive id is still properly updated whenever the URL is updated as well. * Changed the icons for opening the google drive folder * A warning that Google Drive is not configured will be displayed only before save is clicked and the URL has not previously been entered
The reason why the bug was showing up was because the packageset prop was not being updated properly. Fix this problem, and remove the workaround that uses "saved"
This makes it harder to have a mismatch between gdrive_url and gdrive_id, which is not so obvious now that we have removed the gdrive_id field
Collaborator
changyang-liu
left a comment
changyang-liu
left a comment
There was a problem hiding this comment.
I've made a few changes, please do check and see if they work
- I removed the "saved" workaround that you used in favor of fixing the root issue, which was that this.props.ps was not updating correctly
- I made it such that you can't save the url unless gdrive_id has been set to some valid value, which you can think of it as not allowing you to save until you provide a valid url.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.