New tricks and fixes for dungeon logic #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from upstream
winterkid09
commented
Jan 3, 2026
| - run: python3 main.py SKIP_ROM_GENERATION --timeout 120 -s seashells=0 -s heartpiece=0 -s dungeon_keys=keysanity --output /dev/null | ||
| - run: python3 main.py SKIP_ROM_GENERATION --timeout 120 -s logic=glitched -s dungeon_keys=keysanity -s heartpiece=0 -s seashells=0 -s heartcontainers=0 -s instruments=1 -s owlstatues=both -s dungeonshuffle=1 -s witch=0 -s boomerang=gift -s steal=never -s goal=instruments -s goalcount=random --output /dev/null | ||
| - run: python3 main.py SKIP_ROM_GENERATION --timeout 120 -s logic=casual -s dungeon_keys=removed -s itempool=casual --output /dev/null | ||
| - run: python3 main.py SKIP_ROM_GENERATION --timeout 120 -s logic=hell -s overworld=dungeondive -s hardmode=ohko --output /dev/null |
Contributor
Author
There was a problem hiding this comment.
added this test to catch itempool mismatch when damage-dealing tricks that require medicine/toadstool aren't possible due to the overworld not being available, and thus toadstool/medicine is not guaranteed
winterkid09
commented
Jan 3, 2026
| self.add(POWER_BRACELET) | ||
| self.add(SHOVEL) | ||
| self.add(RUPEES_200, 2) | ||
| self.remove("SWITCH7B_RANGE") |
Contributor
Author
There was a problem hiding this comment.
"SWITCH7B_RANGE" only used by diagonal boomerang throw, which is excluded from casual logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are described 1:1 with this google doc: Logic Changes