Open
Conversation
- registry/registry.json: 10 platform skills cataloged - registry/skills/: SKILL.md + scripts for each skill - scripts/skills.sh: list, status, install, push, remove commands - scripts/test-skills.sh: 17 tests (registry integrity, install/remove) - docs/SKILL-REGISTRY-SPEC.md: full architecture spec
dahifi
commented
Apr 4, 2026
Owner
Author
dahifi
left a comment
There was a problem hiding this comment.
🜁 Zephyr Review — PR #26: Phase 1 Skill Registry
Overall: Solid foundation. Clean implementation with good test coverage.
✅ What's good
- Spec doc is thorough — clear tier definitions (platform/client/private), install semantics, migration phases. This is how we should design features.
skills.shis well-structured — mock mode for testing without Docker is smart. Docker env resolution from fleet.json is exactly right for our NAS setup.- Test suite covers the core loop — registry validation, list/install/remove in mock mode, manifest tracking. 8 tests, all meaningful.
- No hardcoded infra — MQTT defaults to Docker DNS (
mosquitto), no IPs or hostnames baked in. - Registry JSON is accurate — correctly catalogs our current platform skills (bus-*, kokoro, resend, stitch, etc.)
📝 Minor notes (non-blocking)
ask-sooknaming — The skill references "Sook" as the parent agent. This is fine as a generic name for the registry, but deployments will need to know this means "escalate to parent." Consider a comment in SKILL.md noting the name is configurable per fleet.bus-command-handler-keepalive— The restart-via-cron approach works but is a bit fragile. Phase 2 could use a proper process supervisor (s6, tini). Not blocking for Phase 1.- E2E CI failure is the pre-existing container health check timeout (needs API key not available in CI) — not caused by this PR.
🔧 Suggestion for follow-up
- Wire
hatch.sh --skillsintegration (Phase 2 in the spec) as a separate PR to keep this one clean.
Verdict: Ready to merge once Michael approves. The spec is sound, the implementation matches, and tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Registry — Phase 1
Adds a skill catalog and CLI for managing skill distribution to hatchlings.
What's in
registry/registry.json— 10 platform skills cataloged (tier, version, deps)registry/skills/— each skill with OC-format SKILL.md + executable scriptsscripts/skills.sh— CLI: list, status, install, push, removescripts/test-skills.sh— 17 tests passingdocs/SKILL-REGISTRY-SPEC.md— full architecture spec (Phase 1-3)Skills cataloged
ask-sook, bus-publish, bus-heartbeat, bus-command-handler, bus-command-handler-keepalive, kokoro, print-doc, resend, stitch, transcribe-voice
Key design decisions
SKILLS_MOCK_ROOT) for testing without DockerPhase 2 (follow-up)